Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(op): implement Call for OpEthApi #9502

Merged
merged 24 commits into from
Jul 16, 2024
Merged

chore(op): implement Call for OpEthApi #9502

merged 24 commits into from
Jul 16, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Jul 15, 2024

  • Implements Call for OpEthApi
  • Removes optimism feature from the default Call implementation

@emhane emhane added C-debt Refactor of code section that is hard to understand or maintain A-rpc Related to the RPC implementation A-op-reth Related to Optimism and op-reth labels Jul 15, 2024
@emhane emhane changed the base branch from main to emhane/node-addons July 15, 2024 09:16
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

blocked until we integrate OPethapi

@mattsse mattsse added the S-blocked This cannot more forward until something else changes label Jul 16, 2024
Base automatically changed from emhane/node-addons to main July 16, 2024 14:06
@emhane emhane removed the S-blocked This cannot more forward until something else changes label Jul 16, 2024
@emhane emhane enabled auto-merge July 16, 2024 15:07
@emhane emhane added this pull request to the merge queue Jul 16, 2024
Merged via the queue into main with commit 55dc12d Jul 16, 2024
32 checks passed
@emhane emhane deleted the emhane/op-ethapi-call branch July 16, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-reth Related to Optimism and op-reth A-rpc Related to the RPC implementation C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants