Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tracing): export tracing-appender crate #9590

Merged
merged 1 commit into from
Jul 17, 2024
Merged

chore(tracing): export tracing-appender crate #9590

merged 1 commit into from
Jul 17, 2024

Conversation

shekhirin
Copy link
Collaborator

Otherwise the return type is unreachable without an additional dependency

reth/crates/tracing/src/lib.rs

Line 179 in 1b5845d

fn init(self) -> eyre::Result<Option<WorkerGuard>>;

@shekhirin shekhirin added C-debt Refactor of code section that is hard to understand or maintain A-observability Related to tracing, metrics, logs and other observability tools labels Jul 17, 2024
@shekhirin shekhirin requested a review from mattsse July 17, 2024 17:33
@shekhirin shekhirin requested a review from onbjerg as a code owner July 17, 2024 17:33
mattsse
mattsse approved these changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reasonable

@shekhirin shekhirin added this pull request to the merge queue Jul 17, 2024
Merged via the queue into main with commit 5c4ce3b Jul 17, 2024
33 checks passed
@shekhirin shekhirin deleted the alexey/tracing-appender-export branch July 17, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
A-observability Related to tracing, metrics, logs and other observability tools C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shekhirin @mattsse