Fix: unreachable code typo

paragonie · Jan 18, 2024 · f41847e · f41847e
1 parent 1fed916
commit f41847e
Showing 1 changed file with 2 additions and 8 deletions.
diff --git a/src/Base64.php b/src/Base64.php
@@ -245,18 +245,12 @@ public static function decodeNoPadding(
             return '';
         }
         if (($srcLen & 3) === 0) {
-            if ($encodedString[$srcLen - 1] === '=') {
+            // If $strLen is not zero and it is divisible by 4, then its at least 4.
+            if ($encodedString[$srcLen - 1] === '=' || $encodedString[$srcLen - 2] === '=') {
                 throw new InvalidArgumentException(
                     "decodeNoPadding() doesn't tolerate padding"
                 );
             }
-            if (($srcLen & 3) > 1) {
-                if ($encodedString[$srcLen - 2] === '=') {
-                    throw new InvalidArgumentException(
-                        "decodeNoPadding() doesn't tolerate padding"
-                    );
-                }
-            }
         }
         return static::decode(
             $encodedString,