Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to Vitest assert #354

Merged
merged 8 commits into from
Jan 19, 2024
Merged

Fixes to Vitest assert #354

merged 8 commits into from
Jan 19, 2024

Conversation

geireann
Copy link
Collaborator

@geireann geireann commented Jan 19, 2024 •
edited
Loading

This PR:

  • Fixes export typing by updating package.json with exports
  • Updates the Vitest assert functionality such that it does not wrap around Vitest it/test functionality.

Note: Vitest has describe, which is different from Riteway's describe.

ericelliott
ericelliott reviewed Jan 19, 2024
View reviewed changes
esm/vitest.test.js Outdated Show resolved Hide resolved
ericelliott
ericelliott approved these changes Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@ericelliott ericelliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericelliott ericelliott merged commit 3303a3d into paralleldrive:master Jan 19, 2024
@ericelliott
Copy link
Collaborator

Published as v8.0.0-RC1

@geireann geireann mentioned this pull request Jan 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericelliott ericelliott ericelliott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geireann @ericelliott