Add suspend. (GC is disabled in the process.)

[albertnetymk]

Similar to futures, suspend has support for both eager and lazy as well. lazy is used by default.

[supercooldave]

If it's an either or situation (either suspend or GC), then perhaps there should be a flag for people not using suspend (or not requiring GC).

Or does that not make sense.

[albertnetymk]

As long as developers don't use suspend in their code, they have full GC support. Is this what you have in mind?

[supercooldave]

Something like this, though it could be a flag that turns on support for suspend (and off GC support).

[albertnetymk]

It's already the case now. GC is disabled for one specific actor from the moment it calls suspend, then it's turned on when that msg runs to completion. Maybe the commit msg is misleading?

[supercooldave]

Your commit message is fine.
I just interpreted it differently.
Perhaps "GC is disables while processing suspend".

[kikofernandez]

Love your commit, it removes more things than it adds!

As a side note, it would be good if we keep a standard when removing last spaces, either we leave them all or we remove them all. Not that it's an important question to address here, but looks like modifications in the code when they are not relevant.

I'll check your code as soon as I arrive to the office

[albertnetymk]

Has anyone else tested this PR? If it's working fine, I would move on to await then.

[supercooldave]

I'll give it a test. But feel free to move on anyway.

[supercooldave]

Looks good. Runs fine on my machine.
@kikofernandez?

[kikofernandez]

started with the code review now! the suspend test passes, let's look at the code

[kikofernandez]

Tested combinations:

• debug with eager and lazy
• release with eager and lazy

My only comment is that in encore.h the public function actor_suspend_resume(ucontext_t* ctx) should be made private, since it's only used inside encore.c. As agreed with @albertnetymk he will do this change in the next PR together with the await fixes.

[supercooldave]

Maybe Albert should be reminded not to branch encore but rather the do a private branch, unless he wants to buy cake for everyone. (If @supercooldave can do things properly, anyone can!)

[kikofernandez]

👍

[supercooldave]

Mikael @EagiZ has already been using this for his project work (code larger than test cases) and it does what it should. Great work!