Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate unique names that do not collide at the C level #159

Merged
merged 2 commits into from
May 17, 2015
Merged

Generate unique names that do not collide at the C level #159

merged 2 commits into from
May 17, 2015

Conversation

EliasC
Copy link
Contributor

@EliasC EliasC commented May 6, 2015

Fixes #69, fixes #94. This commit unifies the generation of C-level
names and adds a unique prefix to all generated names. Makes the
generated code more ugly unfortunately, but on the other hand you can
name your variables "default".

@kikofernandez
Copy link
Contributor

@EliasC could you add a test file for this PR?

@kikofernandez kikofernandez self-assigned this May 8, 2015
@EliasC
Copy link
Contributor Author

EliasC commented May 8, 2015

@kikofernandez Will do!

@kikofernandez
Copy link
Contributor

@EliasC there are some conflicts and it cannot be merged. could you fix the conflicts and rebase? Let me know as soon as you rebase. The PR should be ready to go!

@EliasC
Copy link
Contributor Author

EliasC commented May 17, 2015

It seems there are seven commits that do not belong in this PR added by @kikofernandez. Do you know what's going on?

EliasC added 2 commits May 17, 2015 16:41
Fixes #69, fixes #94. This commit unifies the generation of C-level
names and adds a unique prefix to all generated names. Makes the
generated code more ugly unfortunately, but on the other hand you can
name your variables "default".
@EliasC
Copy link
Contributor Author

EliasC commented May 17, 2015

@kikofernandez I think I fixed it, but could you still check if you accidentally committed some task stuff to my fork? The tests that are failing are async_force_gc, async_foreach and largestream, all without any compiler output which would be the case if there was name problems (and I thought they were all disabled in Jenkins?).

@kikofernandez
Copy link
Contributor

not sure what's going on with those 7 commits... can't see them in the history... I guess you rebased and removed them? My comment was more related to not being able to merge the PR. Tests pass!

kikofernandez pushed a commit that referenced this pull request May 17, 2015
Generate unique names that do not collide at the C level
@kikofernandez kikofernandez merged commit 871a17b into parapluu:master May 17, 2015
@kikofernandez kikofernandez deleted the fix/name-clash branch May 17, 2015 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants