Constrained the type variables for classes #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this fix, the following two pieces of code was accepted: ``` class Foo<int> ``` ``` class Foo<Bar> ``` This is now caught by the parser by making all primitives reserved words and requiring type parameters to begin with a lower case letter.
|
Works for me. Tested by all other tests involving parametric classes, adding a new test would not add anything IMO. |
kaeluka
pushed a commit
that referenced
this pull request
May 10, 2015
Constrained the type variables for classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix, the following two pieces of code were accepted:
This is now caught by the parser by making all primitives reserved words
and requiring type parameters to begin with a lower case letter.