fix #308: parser reads string literals as objects #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 18, 2015 06:58
fix issue #301 where the extract.enc test was not using the "string".equals comparison method but the == method.
this fixes the encore parser where we couldn't use methods on the
strings, i.e. "S".equals("s") threw an exception when parsing this
code. with this fix, the previous example compiles and runs as expected.
|
Looks good! Will merge later today! |
EliasC
added a commit
that referenced
this pull request
Dec 18, 2015
fix #308: parser reads string literals as objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes the encore parser where we couldn't use methods on the strings, i.e. "S".equals("s") threw an exception when parsing this code. with this fix, the previous example compiles and runs as expected.