Fixed a bug related to tracing of traits #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The string replace feels rather unexpected. Could we just drop the tmp variable and use the trace function directly? |
|
Agreed! Fixed to your suggestion. |
|
Can be merged if no objections. |
In certain cases, `CodeGen.Trace.traceCapability` would generate a C-variable containing `->` which would confuse clang. This commit replaces `->` by `_` before generating the name. See `trace.enc` for a test that failed before.
|
Rebased! |
albertnetymk
added a commit
that referenced
this pull request
Feb 24, 2016
Fixed a bug related to tracing of traits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain cases,
CodeGen.Trace.traceCapabilitywould generate aC-variable containing
->which would confuse clang. This commitreplaces
->by_before generating the name. Seetrace.encfor atest that failed before.