Fixed closure import problem when defining a library #336

[PhucVH888]

We have fixed this problem by adding more cases to due with import in Utils.hs

extendAccumProgram f acc0 p@Program{functions, traits, classes, imports} =
  (acc4, p{functions = funs', traits = traits', classes = classes', imports = imports'})

      .......
      (acc4, imports') = List.mapAccumL (extendAccumImport f) acc3 imports
      extendAccumImport f acc i@(PulledImport{iprogram}) =
        (acc', i{iprogram = iprogram'})
        where
          (acc', iprogram') = extendAccumProgram f acc iprogram
      extendAccumImport _ _ _ = error "Util.hs: Non desugared imports during extendAccumProgram"

[EliasC]

Minor comment: You don't need to write the diff in the description, since it's already visible under "Files changed". I'd rather see a more high level description of what was done ("Added more cases" doesn't tell me anything useful). No need to fix it for this PR though as we were all in the room when it was fixed :)

[EliasC]

The big question is who will merge this, as most of us were in the room when it was written! 😮

[PhucVH888]

:)), may be Tobias or Dave, or one of us? But anyway, do we need a testcase with the expected result ?

[EliasC]

But anyway, do we need a testcase with the expected result ?
I think that's a good idea. You could possibly extend one of the module tests to import a closure.

[PhucVH888]

Test case is added.

[EliasC]

Great, is everyone fine with merging this?

[kikofernandez]

yes!

[albertnetymk]

It's best to squash the two commits into one so that you could learn how to use rebase.

[kikofernandez]

+1

[kikofernandez]

@PhucVH888 what's the status of squashing these two commits?

[PhucVH888]

These commits have not been squashed yet. I think it would be nice if you or @albertnetymk can show me how to do this tomorrow.

[kikofernandez]

I agree but first I would recommend that you read the official doc on rebase and, if you are still unsure, we solve your doubts. The important step is that you get a better understanding of the git jargon

[PhucVH888]

I have squashed these two commits.