Fixed generating wrong arguments in stream_mk() #396

[PhucVH888]

The pull request

1. Added the missing argument in stream.h
   From stream_t *stream_mk();. to stream_t *stream_mk(pony_ctx_t *ctx);.
2. Fixed wrong c-code generating in ClassDecl.hs.
   Generate stream_mk(ctx) instead of stream_mk(ctx,ENCORE_PRIMITIVE).
3. Has been tested with make test.

[supercooldave]

Does make test run any extensive tests on Streams?

[PhucVH888]

make test includes largestream.enc, streams.enc, and match.enc.

[kikofernandez]

Do you really need to make the encoreCtxVar an Expr?

[PhucVH888]

I am not pretty sure but it could be used that way. What do you think?

[supercooldave]

Compare the C code for both your version and Kiko's. If Kiko's version make sense, compiles, and passes the tests, then use that.

[PhucVH888]

@kikofernandez : Where is your implementation and which branch should I checkout Kiko?

[EliasC]

Just try to remove AsExpr and see if it compiles!

[PhucVH888]

Yes, it works

[PhucVH888]

I will commit an updated version. Ultimately, I am not so clear what are the differences with and without AsExpr?

[supercooldave]

@PhucVH888 Did you look at the generated C? There you'll see the difference.

[PhucVH888]

@supercooldave There is not any difference.
Both versions (with or without AsExpr) generate the same function stream_t* _stream = stream_mk(_ctx);

As I tested with this example:

class Foo
  stream bar() : int {
    yield 99;
    yield 100;
  }

class Main
  def main() : void
    print(get (new Foo).bar())

[EliasC]

My guess is that there won't be a difference in the generated C. The different kind of C-expressions in CCode (Name, Lval, Expr, Stat and TopLevel) are there to give some extra sanity checking. For example, the lefthand side of an assignment must be an Lval. Writing Haskell code that generates 42 = x will not compile as 42 is an Expr. However, this also means that we sometimes need to use AsExpr when we want to use an Lval where an Expr is expected. In many cases (such as this one), this cast can be inferred by the type system)

[PhucVH888]

Removed AsExpr.