Fix 458 - Test system updates

[kaeluka]

This is the response to #458

• calls module system three times -- FIXED
• remove Makefile in typesyn dir -- FIXED
• empty .fail spec makes test pass -- FIXED
• smaller UI glitches -- FIXED
• can not run individual tests -- FIXED (f.ex bin/test encore/basic/activeThis)
• gracefully handle rubbish input. -- FIXED
• test outputs some rm message -- FIXED

Additionally:

• removed all but one Makefiles

[supercooldave]

It's not so clear which issues were not fixed.
Why should I do the work to decode this information when you could simply provide it?

[supercooldave]

Also, title of the PR will not leave any useful information in the CHANGELOG.md file.

[kaeluka]

• Does not support multiple DISABLED_TESTS.grep files

[kaeluka]

Why should I do the work to decode this information when you could simply provide it?

You're misunderstanding. I sent a PR. I didn't assign you.

[supercooldave]

Why should I do the work to decode this information when you could simply provide it?
You're misunderstanding. I sent a PR. I didn't assign you.

I was suggesting that your comment would have been better to say which aspects of #458 were addressed and which ones were not addressed. Since I need to create another issue regarding the ones not addressed, it would be useful to know which ones they are (rather than having to deduce from the clues left behind.)

[kaeluka]

I'm aware of the one I mentioned above. But only you can have a final say on whether the list is complete -- because you provided most of the input. I might have overlooked something.

[kaeluka]

Does not support multiple DISABLED_TESTS.grep files

that's the one.

[supercooldave]

And the command line arguments .flags file one.

[kaeluka]

IMHO, that's addressed pretty well. We only have one Makefile left, and it's tiny. But further discussion of this should be on the issue that you might create about it.

[supercooldave]

Whether it has been addressed or not, none of the comments above indicate that.

[supercooldave]

Anyway, I'm looking at the PR now.

[kaeluka]

Amended the PR text.

[supercooldave]

This point:

when the script encounters a .enc file without a corresponding .out file, it simply prints the name of the file, and continues. It does not run treat it as a test, which is fine, but it does not say what it has done with the file. The output is exactly the same as for a test that runs and succeeds.

was addressed by completely ignoring the offending files. I would suggest putting a warning to say that a .enc file was encountered but no accompanying .fail etc was found, is more informative, and could help the tester avoid unwanted errors and strange behaviour -- "Why can't the test script see my file???"

[supercooldave]

The output still says

- Importer...
rm: encore/modules/Lib: is a directory

[kaeluka]

• Importer...
  rm: encore/modules/Lib: is a directory

I couldn't reproduce this in the end, so I assumed it had been addressed. Is this directory a temporary one?

[supercooldave]

encore/modules/Lib is an incorrectly named directory in the DISABLED_TESTS file. It should be lowercase lib.

[kaeluka]

fixed!

[kaeluka]

I'll look at the rm thing.

[kaeluka]

The error message should be gone now!

[supercooldave]

Just the comment #463 (comment) above to go.

[kaeluka]

I have to put this task on the back burner for a bit. It'd be better to make an issue about this and deal with it later.

[supercooldave]

I'll merge and try to fix it then.

[kaeluka]

Great, thank you!