Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error handling that broke the compiler #495

Merged
merged 3 commits into from
Jun 16, 2016

Conversation

kikofernandez
Copy link
Contributor

this closes #494 and fixes the compiler

this closes #494 and fixes the compiler
@supercooldave
Copy link

@EliasC We (those of us who eagerly rebase) need this urgently.

@kikofernandez
Copy link
Contributor Author

anyone can review the PR and merge (if you depend on it)

@EliasC
Copy link
Contributor

EliasC commented Jun 16, 2016

I'm on it!

@EliasC
Copy link
Contributor

EliasC commented Jun 16, 2016

Pushed an additional check that Main is active. I have checked @kikofernandez changes, so anyone that checked mine can squash and merge this now!

@albertnetymk
Copy link
Contributor

I don't entirely follow the change in isMainClass. Isn't the second part always true if the first part is ture?

@EliasC
Copy link
Contributor

EliasC commented Jun 16, 2016

I don't entirely follow the change in isMainClass. Isn't the second part always true if the first part is true?

Not in the following program

passive class Main
  def main() : void
    ()

@albertnetymk
Copy link
Contributor

That should not even compile, right?

@EliasC
Copy link
Contributor

EliasC commented Jun 16, 2016

That should not even compile, right?

Exactly! Hence the change in isMainClass :)

@albertnetymk
Copy link
Contributor

I understand it now. Merging now.

It's surprising that it's got in in the first place.

@albertnetymk albertnetymk merged commit a9631aa into parapluu:development Jun 16, 2016
@EliasC EliasC deleted the fix/error-generation branch June 16, 2016 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiler is broken when merging error handler
5 participants