Change code generation for method calls to use the new arg structs. #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 4, 2015 17:18
If a message like this:
def bar(x : int, y : string) : void
print x*2
is called via the bang operator, the argument construction will look
like this:
___encore_Foo_bar_fut_msg _arg_4;
_arg_4.f1 = ({int64_t _literal_2 = 100; _literal_2;});
_arg_4.f2 = ({char* _literal_3 = ""; _literal_3;});
pony_sendv(({ _f_1;}), MSG_Foo__one_way_bar, 2, _arg_4);
This will require giving the argument structs less descriptive names
(`f1`,`f2`,...), but anything else would make expression translation
even harder to comprehend than it is already.
We (Kiko+Stephan) also removed some whitespace.
The fields are now all called `f1`..`fN` like so:
struct encore_Foo_bar_fut_msg
{
encore_fut_msg_t msg;
int64_t f1;
char* f2;
};
This greatly simplifies calling functions (no lookup of the called
function is necessary).
|
Tending to this now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a message like this:
is called via the bang operator, the argument construction will look
like this:
This will require giving the argument structs less descriptive names
(
f1,f2,...), but anything else would make expression translationeven harder to comprehend than it is already.
We (Kiko+Stephan) also removed some whitespace.