-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add _XOPEN_SOURCE in header file to get the right offset in eager strategy #84
Conversation
have you talked to @albertnetymk about adding the |
We just discussed this. This commit shall get us to the state that both coroutine and future are working properly on mac and linux. The reason why I claimed xopen is not needed here is that in lazy version (which is WIP) ucontext info is completely hidden in the runtime, and no userspace code would see it. |
add _XOPEN_SOURCE in header file to get the right offset in eager strategy
@@ -24,6 +24,7 @@ generate_header A.Program{A.etl = A.EmbedTL{A.etlheader}, A.functions, A.classes | |||
IfNDefine "HEADER_H" $ | |||
Concat $ | |||
HashDefine "HEADER_H" : | |||
(HashDefine "_XOPEN_SOURCE 800") : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to get some discussion, shouldn't this line be without parenthesis to follow the surrounding coding style?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are absolutely right. I'll fix it in another commit
Next time, we should wait for a while before merging. After all, PR is meant for code review & discussion. @EliasC For the style in Haskell file, I think so. For the commented C code, |
What's "a while"? |
Don't know exactly how long. Some comments provided by @EliasC should be applied, and rebase should get rid of them, but we didn't do that because insufficent time is provided before merging. |
No description provided.