Introduce peer keyword #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `peer` keyword is a relative of `new`, with the intended semantics that a created actor is created in another work pool, rather than the same as the creating actor. This is the frontend and code generation, the runtime does not support this yet. Instead it will print a warning and revert to the same implementation as `new` for now.
It fails at this point, as the feature is not implemented in the runtime yet.
| do ty' <- checkType ty | ||
| unless (isActiveRefType ty') $ | ||
| tcError $ "Cannot create an object of type '" ++ | ||
| show ty ++ "'" |
There was a problem hiding this comment.
At some point (if this keyword stays) there should also be a special error message for when trying to create passive peers.
|
Looking good! Merging |
|
Thanks! |
|
Ultimately, this will possibly become one of those deployment concerns we haven't yet talked about. |
|
I believe that immediately after creating one actor we send one msg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
peerkeyword is a relative ofnew, with the intendedsemantics that a created actor is created in another work pool,
rather than the same as the creating actor.
This is the frontend and code generation, the runtime does not
support this yet. Instead it will print a warning and revert to the
same implementation as
newfor now.