Replace the use of void* by encore_arg_t #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@EliasC I give you this one since you might recall if we forgot something. Thanks! |
|
Looks good! This commit cleans up a lot of annoying redundancies (and should help us avoid a bunch of warnings from clang). There is some boyscouting to be done (such as |
|
thanks for the review! |
|
You need to merge it if it looks good, not close it! 🎱 |
EliasC
added a commit
that referenced
this pull request
Feb 19, 2015
Replace the use of void* by encore_arg_t
|
Sorry, I thought I clicked merge first... |
|
no problem, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the use of
void*byencore_arg_tin parametric classes, methods and functions and closures relying on type variables