Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): Add existential deposits for foreign assets ✨ #547

Merged
merged 3 commits into from
Dec 7, 2024

Conversation

michaeldev5
Copy link
Collaborator

@michaeldev5 michaeldev5 commented Dec 6, 2024

Closes #548

@michaeldev5 michaeldev5 self-assigned this Dec 6, 2024
Copy link

codecov bot commented Dec 6, 2024

Bundle Report

Changes will increase total bundle size by 26.06kB (4.33%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sdk-cjs-esm 469.12kB 26.06kB (5.88%) ⬆️

@michaeldev5 michaeldev5 force-pushed the feat/foreign-eds branch 3 times, most recently from 9fdca23 to c42dd8b Compare December 6, 2024 19:25
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 97.49373% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...sdk/src/pallets/assets/balance/getBalanceNative.ts 58.82% 6 Missing and 1 partial ⚠️
packages/sdk/src/nodes/supported/Centrifuge.ts 50.00% 2 Missing ⚠️
...es/sdk/src/pallets/assets/getTransferableAmount.ts 98.80% 1 Missing ⚠️
Flag Coverage Δ
visualizator-be 100.00% <ø> (ø)
xcm-analyser 98.60% <ø> (ø)
xcm-api 97.17% <100.00%> (+0.33%) ⬆️
xcm-router 92.55% <ø> (ø)
xcm-sdk 95.75% <95.09%> (-0.03%) ⬇️
Files with missing lines Coverage Δ
apps/xcm-api/src/analytics/EventName.ts 100.00% <ø> (ø)
apps/xcm-api/src/balance/balance.controller.ts 100.00% <100.00%> (ø)
apps/xcm-api/src/balance/balance.service.ts 85.88% <100.00%> (+16.55%) ⬆️
apps/xcm-api/src/balance/dto/BalanceNativeDto.ts 100.00% <100.00%> (ø)
...s/xcm-api/src/balance/dto/ExistentialDepositDto.ts 100.00% <100.00%> (ø)
packages/sdk/src/api/IPolkadotApi.ts 100.00% <ø> (ø)
packages/sdk/src/pallets/assets/assets.ts 87.87% <100.00%> (+3.37%) ⬆️
.../sdk/src/pallets/assets/balance/getAssetBalance.ts 100.00% <100.00%> (ø)
...es/sdk/src/pallets/assets/getExistentialDeposit.ts 100.00% <100.00%> (ø)
...ages/sdk/src/pallets/assets/getOriginFeeDetails.ts 100.00% <100.00%> (ø)
... and 12 more

@michaeldev5 michaeldev5 force-pushed the feat/foreign-eds branch 2 times, most recently from b673296 to 536f0d3 Compare December 6, 2024 21:32
@michaeldev5 michaeldev5 marked this pull request as ready for review December 6, 2024 21:33
@michaeldev5 michaeldev5 force-pushed the feat/foreign-eds branch 2 times, most recently from 35dbc0a to bcdd5b5 Compare December 7, 2024 14:51
@paraspell paraspell deleted a comment from netlify bot Dec 7, 2024
@michaeldev5 michaeldev5 force-pushed the feat/foreign-eds branch 6 times, most recently from 371613f to 785212a Compare December 7, 2024 22:04
@dudo50 dudo50 merged commit 9c5f51f into main Dec 7, 2024
14 checks passed
@dudo50 dudo50 deleted the feat/foreign-eds branch December 7, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add max transferable balance queries
2 participants