Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CLI example work with Windows (update docs.md) #726

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

tim-we
Copy link
Contributor

@tim-we tim-we commented Apr 29, 2024

Using single quotes in the CLI command will cause a panic in the main thread.

> lightningcss --bundle --targets '>= 0.5%' src/app.css -o dist/app.bundle.css

thread 'main' panicked at src/main.rs:191:56:
called `Result::unwrap()` on an `Err` value: Nom("")
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

This PR updates the example code to also work on Windows systems (wasn't immediately obvious that this was the problem).

Using single quotes in the CLI command will cause a panic in the main thread.
@devongovett devongovett merged commit 9a20b58 into parcel-bundler:master Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants