-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add a lint for unsupported CSS Module selector #784
Conversation
Co-authored-by: Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com>
Co-authored-by: Devon Govett <devongovett@gmail.com>
Co-authored-by: Devon Govett <devongovett@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Will do a release tomorrow.
@devongovett Did you do a release? |
crates are now published. I ran into a CI build issue for the npm binaries that I still need to fix, but crates should be usable. |
Thank you! |
Sorry to bother, but this should not have been a patch semver bump but a minor bump, the addition of a new variant to a public enum is breaking some builds.
|
Ah sorry about that, I didn't realize it wasn't pinned. Not sure I can fix it at this point. Will be more careful in the future. |
### What? Update `lightningcss` crate of next.js ### Why? To apply parcel-bundler/lightningcss#784 and parcel-bundler/lightningcss#783 ### How? - Closes PACK-2933 - Closes PACK-3100 - Closes #66191 - Closes #64299
### What? Update `lightningcss` crate of next.js ### Why? To apply parcel-bundler/lightningcss#784 and parcel-bundler/lightningcss#783 ### How? - Closes PACK-2933 - Closes PACK-3100 - Closes #66191 - Closes #64299
Related: vercel/next.js#64299
I made it a parse error because the specification about it is ambiguous thus it's better to bail out.