fix: should not panic when passing system-color to color-mix #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devongovett
approved these changes
Oct 7, 2024
toastal
reviewed
Oct 17, 2024
| if matches!(self, CssColor::CurrentColor) || matches!(other, CssColor::CurrentColor) { | ||
| if matches!(self, CssColor::CurrentColor | CssColor::System(..)) | ||
| || matches!(other, CssColor::CurrentColor | CssColor::System(..)) | ||
| { | ||
| return Err(()); |
There was a problem hiding this comment.
Does this mean you get an error instead of panic? Does the minify_test imply that this will now ‘work’ by not apply but keeping the existing colors in color-mix in this case? I don’t know Rust…
There was a problem hiding this comment.
it'll fall back to an unparsed property, which will preserve the original source as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #685
playground repo