add new logger warning when both minBundleSize and disableSharedBundl…

…es are manually set
parcel-bundler · Aug 22, 2023 · fd2cdaa · fd2cdaa
1 parent cbce809
commit fd2cdaa
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/packages/bundlers/default/src/DefaultBundler.js b/packages/bundlers/default/src/DefaultBundler.js
@@ -20,6 +20,7 @@ import invariant from 'assert';
 import {ALL_EDGE_TYPES} from '@parcel/graph';
 import {Bundler} from '@parcel/plugin';
 import {setEqual, validateSchema, DefaultMap, BitSet} from '@parcel/utils';
+import logger from '@parcel/logger';
 import nullthrows from 'nullthrows';
 import {encodeJSONKeyComponent} from '@parcel/diagnostic';
 
@@ -1369,6 +1370,17 @@ async function loadBundlerConfig(
 
   invariant(conf?.contents != null);
 
+  // minBundles value will be ignored if shared bundles are disabled
+  if (
+    conf.contents.minBundleSize != null &&
+    conf.contents.disableSharedBundles === true
+  ) {
+    logger.warn({
+      origin: '@parcel/bundler-default',
+      message: `The value of "${conf.contents.minBundleSize}" set for minBundleSize will not be used as shared bundles have been disabled`,
+    });
+  }
+
   validateSchema.diagnostic(
     CONFIG_SCHEMA,
     {

diff --git a/packages/core/parcel/package.json b/packages/core/parcel/package.json
@@ -14,7 +14,7 @@
     "type": "git",
     "url": "https://github.com/parcel-bundler/parcel.git"
   },
-  "bin": "src/bin.js",
+  "bin": "lib/bin.js",
   "main": "lib/bin.js",
   "source": "src/bin.js",
   "engines": {

diff --git a/packages/utils/create-react-app/package.json b/packages/utils/create-react-app/package.json
@@ -2,7 +2,7 @@
   "name": "@parcel/create-react-app",
   "version": "2.9.3",
   "bin": {
-    "parcel-create-react-app": "src/bin.js"
+    "parcel-create-react-app": "lib/bin.js"
   },
   "main": "src/bin.js",
   "repository": {