Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.posthtmlrc
plugins can now havetrue
instead of an empty object when no configuration is needed.This conforms to the documentation: https://parceljs.org/html.html#posthtml.
↪️ Pull Request
This resolves #3156 (That is already closed, but not fixed).
So when using posthtml plugins, sometimes no configuration is required, and according to parcel's official documentation
The problem was that for some reason(I don't know why) the object for the settings of each plugin is modified by using
Object.assign(pluginsSettings, settingsToAdd)
.However, when
Object.assign
is passed a boolean as the first argument it fails silently(technically the operation is performed, but its still a boolean, so there is no access to those props anymore).You can see the code for the fix, but basically, I did it that way in order to avoid an
if
check.🚨 Test instructions
To be honest im not familiar enough with the internals of Parcel to do a good test.
✔️ PR Todo