-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Micromatch #6958
Update Micromatch #6958
Conversation
|
Some tests in https://github.com/parcel-bundler/parcel/blob/v2/packages/utils/node-resolver-core/test/resolver.js fail now, because the two micromatch versions have a slightly different behaviour: |
Would you like me to try and update the tests to work with the change? |
No, the tests are correct and specify the intended behavior of Parcel. You need to adjust how micromatch is called in the implementation or use a different glob matching library if that doesn't work out. |
(Hopefully) final question, what dependency am I missing if literally every test fails with the following:
edit: never mind, apparently installing rustup wasn't the final step of installing rustup |
I've just had a go at debugging this, and I think it's hitting micromatch/picomatch#77. |
↪️ Pull Request
Updates micromatch to remove security vulnerability, as described in #6942.
EDIT: probably closes #6942
✔️ PR Todo