Only add export setter for non-esm exports #8910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark ResultsKitchen Sink ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. React HackerNews ✅
Timings
Cold Bundles
Cached BundlesNo bundle changes detected. AtlasKit Editor ✅
Timings
Cold Bundles
Cached Bundles
Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached Bundles
|
|
We should add an integration test |
|
@mischnic Integration test added 👍 |
thebriando
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
This PR resolves an issue where Parcel would generate code that could potentially re-assign a
constexport. When running this code through the SWC optimizer it would throw the following error:cannot reassign to a variable declared with const. The runtime code that allows reassignment of exports is only needed for CJS exports, however Parcel currently adds it for all exports in the case it detects any CJS usage in the file (e.g. when using mixed files with both CJS and ESM 🤢).This PR makes the scope hoisting packager aware which exports were declared with ESM syntax and avoids adding the reassignment code for those exports.
Note: I've just added
isEsmto the asset symbol metadata for now which means it's untyped and kind of hidden. Might be good to make it a first class property at some point?💻 Examples
🚨 Test instructions
✔️ PR Todo