Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing asset errors in runtime manifest bundles #8981

Merged
merged 6 commits into from
May 8, 2023

Conversation

mattcompiles
Copy link
Contributor

@mattcompiles mattcompiles commented May 3, 2023

↪️ Pull Request

This PR fixes an issue where runtime manifest bundles could cause bundles to be missing from the register code, causing a runtime error (Error: Could not resolve bundle with id abKQ5).

This issue would occur when a runtime manifest bundle was split out from the bundle group entry but one (or more) of it's parents runtimes had already been processed, causing the new bundle to be missing from the register code.

Previously we were processing the bundles in reverse order to handle this issue, but that only minimised the issue and didn't eliminate it completely. The fix here is to process the bundles in reverse topological order which means all child bundles will be processed before their parents.

🚨 Test instructions

As this is just a slight modification of the existing code I haven't added more tests scenarios.

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@mischnic
Copy link
Member

mischnic commented May 3, 2023

Is there some easy simple case you can add? Runtimes will (hopefully) be overhauled at some point in the future and this might break again

@mattcompiles mattcompiles requested a review from mischnic May 5, 2023 01:34
@mattcompiles
Copy link
Contributor Author

@mischnic Added a test case mate 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants