Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't confuse workers with no-opt command line option #9239

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

danieltroger
Copy link
Contributor

↪️ Pull Request

Maybe fixes #9237

💻 Examples

See #9237

🚨 Test instructions

You can try setting up docker and node like described in the discussion above. But I don't see how this could hurt? Let's just try it and maybe it works.

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@mischnic
Copy link
Member

You can try setting up docker and node like described in the discussion above. But I don't see how this could hurt? Let's just try it and maybe it works.

Or: set NODE_OPTIONS="--opt" which something in your setup does

@danieltroger
Copy link
Contributor Author

danieltroger commented Sep 12, 2023

Or: set NODE_OPTIONS="--opt" which something in your setup does

I tried that, the problem is that it yields
/Users/daniel/.nvm/versions/node/v20.5.0/bin/node: --opt is not allowed in NODE_OPTIONS

And --no-opt

/Users/daniel/.nvm/versions/node/v20.5.0/bin/node: --no-opt is not allowed in NODE_OPTIONS

@mischnic
Copy link
Member

mischnic commented Sep 12, 2023

I guess it has be injected in some other way then, e.g. by overriding the node binary on PATH or

$ node --opt
Welcome to Node.js v18.17.1.
Type ".help" for more information.
> process.execArgv
[ '--opt' ]

@danieltroger
Copy link
Contributor Author

danieltroger commented Sep 12, 2023

I manipulated my path and the argument is there when running node

daniel@mmmmmmmmmm utilishared % node                   
Welcome to Node.js v20.5.0.
Type ".help" for more information.
> process.execArgv
[ '--no-opt' ]
> 

but yarn parcel build still succeeds for me (suggesting that the option is not respected).
However, I did this change with a yarn patch and now my Dockerfile seems to get further.

EDIT: yup, my docker image builds successfully now 🎉

@mischnic mischnic merged commit d095514 into parcel-bundler:v2 Sep 13, 2023
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants