Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node: should always be a builtin #9250

Merged
merged 2 commits into from
Sep 18, 2023
Merged

node: should always be a builtin #9250

merged 2 commits into from
Sep 18, 2023

Conversation

mischnic
Copy link
Member

@ExE-Boss pointed out that node: should always be a builtin. This is also what the ESM codepath does for node:

@parcel-benchmark
Copy link

parcel-benchmark commented Sep 16, 2023

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 1.48s -21.00ms
Cached 289.00ms -6.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

React HackerNews ✅

Timings

Description Time Difference
Cold 4.19s -39.00ms
Cached 431.00ms +7.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/PermalinkedComment.3145598b.js 3.94kb +0.00b 370.00ms +25.00ms ⚠️
dist/UserProfile.b37bbaff.js 1.38kb +0.00b 369.00ms +24.00ms ⚠️
dist/NotFound.c08212ea.js 265.00b +0.00b 369.00ms +24.00ms ⚠️
dist/logo.8dd07848.png 244.00b +0.00b 264.00ms +14.00ms ⚠️

Cached Bundles

Bundle Size Difference Time Difference
dist/PermalinkedComment.3145598b.js 3.94kb +0.00b 382.00ms +45.00ms ⚠️
dist/UserProfile.b37bbaff.js 1.38kb +0.00b 382.00ms +45.00ms ⚠️
dist/NotFound.c08212ea.js 265.00b +0.00b 382.00ms +45.00ms ⚠️

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 37.42s -1.39s
Cached 2.45s +8.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/refractor.61b4c5e1.js 601.68kb +0.00b 12.28s -1.38s 🚀
dist/media-viewer.bc1a2415.js 537.32kb +0.00b 11.78s -1.88s 🚀
dist/popup.32b3d0ef.js 324.46kb +0.00b 12.28s -1.38s 🚀
dist/ConfigPanelFieldsLoader.8648eeee.js 306.81kb +0.00b 9.46s -2.97s 🚀
dist/EmojiPickerComponent.c199902f.js 189.68kb +0.00b 12.27s -1.43s 🚀
dist/card.3521c96b.js 140.18kb +0.00b 9.45s -2.98s 🚀
dist/ConfigPanelFieldsLoader.1a016f33.js 82.96kb +0.00b 12.27s -1.39s 🚀
dist/esm.5b5f7c9f.js 63.36kb +0.00b 12.28s -1.38s 🚀
dist/ElementBrowser.c496dd44.js 62.20kb +0.00b 9.46s -2.97s 🚀
dist/archive.fe044de4.js 60.16kb +0.00b 12.17s -1.49s 🚀
dist/esm.ce3e12df.js 59.72kb +0.00b 9.46s -2.97s 🚀
dist/DatePicker.f4cb448f.js 47.85kb +0.00b 6.74s -347.00ms 🚀
dist/esm.f9edadb2.js 39.42kb +0.00b 12.28s -1.41s 🚀
dist/DatePicker.412226fe.js 25.02kb +0.00b 6.74s -347.00ms 🚀
dist/smartMediaEditor.226eb0f2.js 21.76kb +0.00b 12.28s -1.41s 🚀
dist/esm.a421c1ca.js 20.52kb +0.00b 12.28s -1.41s 🚀
dist/dropzone.452cdf0e.js 13.48kb +0.00b 12.28s -1.38s 🚀
dist/pdfRenderer.6335b9a2.js 12.08kb +0.00b 9.45s -2.98s 🚀
dist/dropzone.eff4ce1e.js 11.51kb +0.00b 12.28s -1.41s 🚀
dist/Toolbar.759db587.js 9.40kb +0.00b 12.28s -1.41s 🚀
dist/clipboard.121b0510.js 7.94kb +0.00b 12.28s -1.38s 🚀
dist/mobile-upload.c687ddb2.js 7.86kb +0.00b 9.46s -2.97s 🚀
dist/mobile-upload.e9eb996a.js 7.86kb +0.00b 9.46s -2.97s 🚀
dist/mobile-upload.d7818b6e.js 7.86kb +0.00b 12.28s -1.41s 🚀
dist/index.runtime.1064c960.js 7.29kb +0.00b 12.28s -1.41s 🚀
dist/browser.857fa69b.js 7.20kb +0.00b 12.28s -1.38s 🚀
dist/index.b16227d6.css 4.08kb +0.00b 12.28s -1.42s 🚀
dist/media-viewer-analytics-error-boundary.54c54975.js 3.19kb +0.00b 12.28s -1.38s 🚀
dist/media-picker-analytics-error-boundary.6a30027d.js 3.19kb +0.00b 12.28s -1.41s 🚀
dist/media-card-analytics-error-boundary.b80de757.js 3.19kb +0.00b 12.28s -1.38s 🚀
dist/codeViewerRenderer.7d374cd5.js 2.61kb +0.00b 9.45s -2.98s 🚀
dist/ResourcedEmojiComponent.184d62aa.js 2.47kb +0.00b 6.74s -347.00ms 🚀
dist/pl.f089a702.js 2.25kb +0.00b 6.74s -736.00ms 🚀
dist/cs.c0d356c1.js 2.23kb +0.00b 6.74s -347.00ms 🚀
dist/de.1a167b65.js 2.17kb +0.00b 6.74s -347.00ms 🚀
dist/fr.6cc5b166.js 2.12kb +0.00b 6.74s -737.00ms 🚀
dist/es.38a88442.js 2.12kb +0.00b 6.74s -347.00ms 🚀
dist/hu.026ff8dd.js 2.10kb +0.00b 6.74s -738.00ms 🚀
dist/fi.84541eb7.js 2.09kb +0.00b 6.74s -737.00ms 🚀
dist/ja.a9cd0bd6.js 2.09kb +0.00b 6.74s -738.00ms 🚀
dist/pt_BR.1db6fd92.js 2.06kb +0.00b 6.74s -736.00ms 🚀
dist/ko.954590a1.js 1.97kb +0.00b 6.74s -737.00ms 🚀
dist/it.5c7edaaf.js 1.97kb +0.00b 6.74s -738.00ms 🚀
dist/nb.7f52770f.js 1.96kb +0.00b 6.74s -737.00ms 🚀
dist/date.6db71354.js 1.94kb +0.00b 5.99s -305.00ms 🚀
dist/da.23f674ea.js 1.94kb +0.00b 6.74s -347.00ms 🚀
dist/nl.fd54481e.js 1.94kb +0.00b 6.74s -737.00ms 🚀
dist/images.21df3a8f.js 1.90kb +0.00b 5.99s -305.00ms 🚀
dist/feedback.647089cf.js 1.76kb +0.00b 6.74s -347.00ms 🚀
dist/status.be4e3842.js 1.67kb +0.00b 5.99s -305.00ms 🚀
dist/code.64a301f3.js 1.56kb +0.00b 5.99s -305.00ms 🚀
dist/workerHasher.322762e4.js 1.56kb +0.00b 9.46s -2.97s 🚀
dist/workerHasher.8fdadeba.js 1.56kb +0.00b 9.46s -2.97s 🚀
dist/workerHasher.65b703b7.js 1.56kb +0.00b 12.28s -1.38s 🚀
dist/workerHasher.100ea0bf.js 1.56kb +0.00b 12.28s -1.41s 🚀
dist/workerHasher.81697bdc.js 1.56kb +0.00b 12.28s -1.41s 🚀
dist/list-number.e454dc8e.js 1.47kb +0.00b 5.99s -305.00ms 🚀
dist/heading6.eae34279.js 1.36kb +0.00b 6.74s -347.00ms 🚀
dist/heading3.82217cc7.js 1.35kb +0.00b 5.99s -304.00ms 🚀
dist/link.ef87b7d4.js 1.28kb +0.00b 5.99s -305.00ms 🚀
dist/emoji.f9caa19f.js 1.25kb +0.00b 5.99s -304.00ms 🚀
dist/heading5.20183aa6.js 1.23kb +0.00b 6.74s -347.00ms 🚀
dist/expand.e7437f2e.js 1.18kb +0.00b 6.74s -347.00ms 🚀
dist/heading2.a43a84af.js 1.17kb +0.00b 5.99s -304.00ms 🚀
dist/heading4.bc1ea347.js 1.12kb +0.00b 5.99s -1.06s 🚀
dist/mention.12d040af.js 1.08kb +0.00b 5.99s -305.00ms 🚀
dist/layout.467fc22b.js 1.04kb +0.00b 5.99s -305.00ms 🚀
dist/divider.875eeb9b.js 1.04kb +0.00b 5.99s -304.00ms 🚀
dist/action.4747cf93.js 1.02kb +0.00b 5.99s -305.00ms 🚀
dist/heading1.a2a2d506.js 1.01kb +0.00b 5.99s -304.00ms 🚀
dist/list.a024d070.js 1007.00b +0.00b 5.99s -305.00ms 🚀
dist/quote.790784b0.js 1007.00b +0.00b 5.99s -305.00ms 🚀
dist/decision.f09ec841.js 988.00b +0.00b 5.99s -305.00ms 🚀
dist/panel-warning.b246d7d3.js 964.00b +0.00b 5.99s -305.00ms 🚀
dist/16.792a9556.js 951.00b +0.00b 5.99s -304.00ms 🚀
dist/table.348d2eb0.js 942.00b +0.00b 5.99s -304.00ms 🚀
dist/panel.bc621c8f.js 883.00b +0.00b 5.99s -305.00ms 🚀
dist/panel-error.9152f129.js 860.00b +0.00b 5.99s -306.00ms 🚀
dist/16.eb6f51c1.js 817.00b +0.00b 5.99s -304.00ms 🚀
dist/panel-success.25629fed.js 801.00b +0.00b 5.99s -306.00ms 🚀
dist/panel-note.f23dd251.js 791.00b +0.00b 5.99s -306.00ms 🚀
dist/16.d9cd1f88.js 742.00b +0.00b 5.99s -304.00ms 🚀
dist/pt_PT.16308ef8.js 631.00b +0.00b 6.74s -2.41s 🚀
dist/et.3d28125f.js 629.00b +0.00b 6.74s -347.00ms 🚀
dist/simpleHasher.0488d56a.js 585.00b +0.00b 9.46s -2.97s 🚀
dist/simpleHasher.180c1d91.js 585.00b +0.00b 9.46s -2.97s 🚀
dist/simpleHasher.88f1b387.js 585.00b +0.00b 12.28s -1.38s 🚀
dist/simpleHasher.2c36efc2.js 585.00b +0.00b 12.28s -1.41s 🚀
dist/simpleHasher.37be2994.js 585.00b +0.00b 12.28s -1.41s 🚀
dist/is.b5f0121f.js 491.00b +0.00b 6.74s -738.00ms 🚀
dist/en_GB.f6c48dd5.js 468.00b +0.00b 6.74s -347.00ms 🚀
dist/en.b8f14ffb.js 465.00b +0.00b 6.74s -346.00ms 🚀
dist/index.html 248.00b +0.00b 6.71s -7.01s 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/media-viewer.bc1a2415.js 537.32kb +0.00b 9.59s -2.90s 🚀
dist/ConfigPanelFieldsLoader.8648eeee.js 306.81kb +0.00b 9.59s -1.74s 🚀
dist/card.3521c96b.js 140.18kb +0.00b 9.58s -1.75s 🚀
dist/ElementBrowser.c496dd44.js 62.20kb +0.00b 9.59s +676.00ms ⚠️
dist/archive.fe044de4.js 60.16kb +0.00b 9.59s -2.90s 🚀
dist/esm.ce3e12df.js 59.72kb +0.00b 9.59s -1.74s 🚀
dist/component-lazy.aeb22f50.js 59.50kb +0.00b 5.95s -705.00ms 🚀
dist/ConfigPanelFieldsLoader.8efb299e.js 15.82kb +0.00b 9.59s +676.00ms ⚠️
dist/ui.8e1e1200.js 14.49kb +0.00b 9.59s +676.00ms ⚠️
dist/ConfigPanelFieldsLoader.f78f3b60.js 13.65kb +0.00b 9.59s +676.00ms ⚠️
dist/pdfRenderer.6335b9a2.js 12.08kb +0.00b 9.59s -2.41s 🚀
dist/mobile-upload.c687ddb2.js 7.86kb +0.00b 9.59s -1.74s 🚀
dist/mobile-upload.e9eb996a.js 7.86kb +0.00b 9.59s -1.74s 🚀
dist/media-viewer-analytics-error-boundary.54c54975.js 3.19kb +0.00b 9.59s -2.90s 🚀
dist/uk.5d2e97bd.js 2.76kb +0.00b 9.59s +676.00ms ⚠️
dist/codeViewerRenderer.7d374cd5.js 2.61kb +0.00b 9.59s -2.90s 🚀
dist/th.df60823c.js 2.60kb +0.00b 9.59s +676.00ms ⚠️
dist/pl.f089a702.js 2.25kb +0.00b 6.68s -647.00ms 🚀
dist/ja.a9cd0bd6.js 2.09kb +0.00b 6.68s -648.00ms 🚀
dist/vi.3e6d5bcb.js 2.09kb +0.00b 9.59s +676.00ms ⚠️
dist/pt_BR.1db6fd92.js 2.06kb +0.00b 8.56s +1.23s ⚠️
dist/tr.4de346b9.js 2.03kb +0.00b 9.59s +676.00ms ⚠️
dist/ko.954590a1.js 1.97kb +0.00b 6.68s -647.00ms 🚀
dist/sv.b893ead3.js 1.97kb +0.00b 9.59s +676.00ms ⚠️
dist/it.5c7edaaf.js 1.97kb +0.00b 6.68s -647.00ms 🚀
dist/nb.7f52770f.js 1.96kb +0.00b 6.68s -647.00ms 🚀
dist/nl.fd54481e.js 1.94kb +0.00b 6.68s -647.00ms 🚀
dist/zh_TW.3d130b76.js 1.85kb +0.00b 9.59s +676.00ms ⚠️
dist/zh.fb21f066.js 1.83kb +0.00b 9.59s +676.00ms ⚠️
dist/workerHasher.322762e4.js 1.56kb +0.00b 9.59s +676.00ms ⚠️
dist/workerHasher.8fdadeba.js 1.56kb +0.00b 9.59s -1.74s 🚀
dist/heading5.20183aa6.js 1.23kb +0.00b 5.95s -728.00ms 🚀
dist/pt_PT.16308ef8.js 631.00b +0.00b 8.56s +1.23s ⚠️
dist/simpleHasher.0488d56a.js 585.00b +0.00b 9.59s +676.00ms ⚠️
dist/simpleHasher.180c1d91.js 585.00b +0.00b 9.59s -1.74s 🚀
dist/index.html 248.00b +0.00b 5.68s -6.86s 🚀

Three.js ✅

Timings

Description Time Difference
Cold 3.12s -70.00ms
Cached 336.00ms -22.00ms 🚀

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@mischnic mischnic merged commit 5ac4567 into v2 Sep 18, 2023
16 checks passed
@mischnic mischnic deleted the node-prefix-cjs-fixup branch September 18, 2023 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants