Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WebExtensionTransformer.js resolve side_panel.defaul_path #9257

Closed
wants to merge 1 commit into from

Conversation

atl-jlandaverde
Copy link

@atl-jlandaverde atl-jlandaverde commented Sep 20, 2023

Chrome's config for side panels uses side_panel.config instead of sidebar_action.default_panel.

https://developer.chrome.com/docs/extensions/reference/sidePanel/#use-cases

↪️ Pull Request

Chrome uses a different property to configure side panels. It uses side_panel.default_path instead of sidebar_action.default_panel. As a result we can't configure a side panel for a chrome extension

💻 Examples

In a manifest.json use the following configuration for a side panel.

{
  "name": "My side panel extension",
  ...
  "side_panel": {
    "default_path": "sidepanel.html"
  }
  ...
}

🚨 Test instructions

Configure you manifest.json for to use a side panel. Check the bundle and it should transform side_panel.default_path
{
"name": "My side panel extension",
...
"side_panel": {
"default_path": "sidepanel.html"
}
...
}

✔️ PR Todo

  • Added/updated unit tests for this change - No tests for this file
  • Filled out test instructions (In case there aren't any unit tests)
  • [ x] Included links to related issues/PRs - Did not find any

Chrome's config for side panels uses side_panel.config instead of sidebar_action.default_panel. 

https://developer.chrome.com/docs/extensions/reference/sidePanel/#use-cases
@mischnic
Copy link
Member

Could you add this entry to the test case here?

@mischnic
Copy link
Member

Thank you for the PR, but I just noticed that we already have a PR for this property that also has tests: #9178

@mischnic mischnic closed this Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants