Update WebExtensionTransformer.js resolve side_panel.defaul_path #9257
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome's config for side panels uses side_panel.config instead of sidebar_action.default_panel.
https://developer.chrome.com/docs/extensions/reference/sidePanel/#use-cases
↪️ Pull Request
Chrome uses a different property to configure side panels. It uses side_panel.default_path instead of sidebar_action.default_panel. As a result we can't configure a side panel for a chrome extension
💻 Examples
In a manifest.json use the following configuration for a side panel.
🚨 Test instructions
Configure you manifest.json for to use a side panel. Check the bundle and it should transform side_panel.default_path
{
"name": "My side panel extension",
...
"side_panel": {
"default_path": "sidepanel.html"
}
...
}
✔️ PR Todo