Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix index page loading in dev server when bundle type isn't html #9282

Merged
merged 1 commit into from
Oct 1, 2023

Conversation

devongovett
Copy link
Member

In React Spectrum, we have a custom namer plugin that names JS bundles with an html extension because a packager will actually run the JS and output HTML. At some point the dev server stopped serving the index pages. This changes the bundle type check to use the extension of the bundle name instead.

@parcel-benchmark
Copy link

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 2.07s -14.00ms
Cached 366.00ms -8.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 399.00ms +36.00ms ⚠️
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 401.00ms +37.00ms ⚠️
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 409.00ms +45.00ms ⚠️
dist/legacy/index.ff03421b.js 1.48kb +0.00b 591.00ms +51.00ms ⚠️
dist/legacy/index.e9bb1616.js 1.06kb +0.00b 592.00ms +52.00ms ⚠️
dist/modern/index.4a29d309.js 921.00b +0.00b 592.00ms +53.00ms ⚠️
dist/legacy/index.html 826.00b +0.00b 629.00ms +49.00ms ⚠️
dist/modern/index.html 749.00b +0.00b 628.00ms +48.00ms ⚠️

React HackerNews ✅

Timings

Description Time Difference
Cold 5.32s -263.00ms
Cached 619.00ms +75.00ms ⚠️

Cold Bundles

Bundle Size Difference Time Difference
dist/index.js 459.11kb +0.00b 1.23s -166.00ms 🚀
dist/PermalinkedComment.e9dc4a75.js 3.92kb +0.00b 454.00ms -74.00ms 🚀
dist/UserProfile.8945a243.js 1.38kb +0.00b 454.00ms -74.00ms 🚀
dist/NotFound.8b44a81d.js 269.00b +0.00b 454.00ms -74.00ms 🚀
dist/logo.8dd07848.png 244.00b +0.00b 328.00ms -46.00ms 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/index.js 459.11kb +0.00b 1.27s -67.00ms 🚀
dist/logo.8dd07848.png 244.00b +0.00b 312.00ms -95.00ms 🚀

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 48.10s -1.09s
Cached 2.99s +41.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/media-viewer.38e3999a.js 536.13kb +0.00b 15.48s +3.96s ⚠️
dist/ConfigPanelFieldsLoader.182d39bc.js 303.43kb +0.00b 10.96s -578.00ms 🚀
dist/card.d06de810.js 138.91kb +0.00b 10.93s -593.00ms 🚀
dist/ElementBrowser.e8f01080.js 61.94kb +0.00b 10.94s -593.00ms 🚀
dist/esm.bfca2115.js 59.30kb +0.00b 10.96s -579.00ms 🚀
dist/ConfigPanelFieldsLoader.2b7c03be.js 15.74kb +0.00b 10.94s -592.00ms 🚀
dist/ui.8c117104.js 14.48kb +0.00b 10.94s -593.00ms 🚀
dist/ConfigPanelFieldsLoader.5dfde67d.js 13.63kb +0.00b 10.94s -592.00ms 🚀
dist/pdfRenderer.01deafa1.js 12.04kb +0.00b 10.93s -592.00ms 🚀
dist/mobile-upload.3baad8e4.js 7.79kb +0.00b 10.96s -578.00ms 🚀
dist/mobile-upload.7a892a37.js 7.79kb +0.00b 10.96s -578.00ms 🚀
dist/ru.0cf3f40e.js 2.81kb +0.00b 10.94s -593.00ms 🚀
dist/uk.282f23b1.js 2.76kb +0.00b 10.94s -592.00ms 🚀
dist/th.137e1013.js 2.60kb +0.00b 10.94s -592.00ms 🚀
dist/vi.b46097db.js 2.09kb +0.00b 10.94s -592.00ms 🚀
dist/tr.c85d90a9.js 2.03kb +0.00b 10.94s -592.00ms 🚀
dist/sv.1c06c95c.js 1.98kb +0.00b 10.94s -592.00ms 🚀
dist/zh_TW.b7c55aa6.js 1.86kb +0.00b 10.94s -593.00ms 🚀
dist/zh.b01fe721.js 1.84kb +0.00b 10.94s -592.00ms 🚀
dist/workerHasher.540c9790.js 1.56kb +0.00b 10.94s -599.00ms 🚀
dist/workerHasher.c840c607.js 1.56kb +0.00b 10.96s -578.00ms 🚀
dist/sk.4be9c93f.js 656.00b +0.00b 10.94s -593.00ms 🚀
dist/simpleHasher.c14e20b4.js 589.00b +0.00b 10.96s -579.00ms 🚀
dist/simpleHasher.23db7a52.js 589.00b +0.00b 10.96s -578.00ms 🚀
dist/ro.8d5b380a.js 482.00b +0.00b 10.93s -594.00ms 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/component-lazy.51d1dec9.js 58.94kb +0.00b 8.60s +1.28s ⚠️
dist/ru.0cf3f40e.js 2.81kb +0.00b 11.88s +831.00ms ⚠️
dist/codeViewerRenderer.51140ec8.js 2.61kb +0.00b 16.69s +5.26s ⚠️
dist/sk.4be9c93f.js 656.00b +0.00b 11.88s +831.00ms ⚠️
dist/ro.8d5b380a.js 482.00b +0.00b 11.88s +3.60s ⚠️

Three.js ✅

Timings

Description Time Difference
Cold 4.16s -48.00ms
Cached 433.00ms +17.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/Three.js 572.25kb +0.00b 1.27s -105.00ms 🚀

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@mischnic mischnic merged commit 830d755 into v2 Oct 1, 2023
16 checks passed
@mischnic mischnic deleted the fix-index branch October 1, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants