Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable scope hoisting when 'this' points to an export #9291

Merged
merged 24 commits into from
Oct 11, 2023
Merged

Disable scope hoisting when 'this' points to an export #9291

merged 24 commits into from
Oct 11, 2023

Commits on Oct 4, 2023

  1. recognize 'this' as a potential keyword linking to an export

    achan3 committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    ea9ac58 View commit details
    Browse the repository at this point in the history

  2. Add co-authors. 

    Co-authored-by: Eric Eldredge <lettertwo@gmail.com>
Co-authored-by: Brian Tedder <btedder@atlassian.com>
    achan3 committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    962fb94 View commit details
    Browse the repository at this point in the history

  3. update BailoutReason text, fix test name

    Brian Tedder committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    0b286b1 View commit details
    Browse the repository at this point in the history

  4. rename "thises" to "this_exprs"

    Brian Tedder committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    f25069d View commit details
    Browse the repository at this point in the history

  5. remove print statements

    Brian Tedder committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    053a3e3 View commit details
    Browse the repository at this point in the history

  6. cleanup

    Brian Tedder committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    d8df4be View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. don't wrap when this collides in class

    Brian Tedder committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    649f8d9 View commit details
    Browse the repository at this point in the history

  2. move bailouts outside of tracing

    achan3 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    41676e0 View commit details
    Browse the repository at this point in the history

  3. add integration test

    achan3 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    fd15591 View commit details
    Browse the repository at this point in the history

  4. cleanup integration test

    achan3 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    844bbd6 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. Merge branch 'v2' into disable-scope-hoisting-for-all-exports

    @imbrian
    imbrian authored Oct 6, 2023
    Configuration menu
    Copy the full SHA
    2895285 View commit details
    Browse the repository at this point in the history

  2. update test: move to commonjs and change search

    achan3 committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    93d566d View commit details
    Browse the repository at this point in the history

  3. update naming

    achan3 committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    df4a133 View commit details
    Browse the repository at this point in the history

  4. Update packages/core/integration-tests/test/scope-hoisting.js 

    Co-authored-by: Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com>
    @adelchan07 @mischnic
    adelchan07 and mischnic authored Oct 6, 2023
    Configuration menu
    Copy the full SHA
    c22d900 View commit details
    Browse the repository at this point in the history

  5. move fixture for test into commonjs folder

    achan3 committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    bec3225 View commit details
    Browse the repository at this point in the history

  6. update link for THisInExport bailout reason

    achan3 committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    d677c71 View commit details
    Browse the repository at this point in the history

  7. remove duplicate memberProp check

    achan3 committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    a017082 View commit details
    Browse the repository at this point in the history

  8. Revert "remove duplicate memberProp check" 

    This reverts commit a017082.
    achan3 committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    04c82d8 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. Merge branch 'v2' into disable-scope-hoisting-for-all-exports

    achan3 committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    dd03ed7 View commit details
    Browse the repository at this point in the history

  2. store Ident, Span instead of entire node

    Brian Tedder committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    af24783 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'v2' into disable-scope-hoisting-for-all-exports

    achan3 committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    f33be22 View commit details
    Browse the repository at this point in the history

  4. move instead of clone self.this_exprs

    achan3 committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    751624c View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. Cleanup

    @mischnic
    mischnic authored Oct 11, 2023
    Configuration menu
    Copy the full SHA
    e33a459 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'v2' into disable-scope-hoisting-for-all-exports

    achan3 committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    f116cad View commit details
    Browse the repository at this point in the history