-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Progress messages for writing to cache #9368
Conversation
Should the progress bar rendering be the responsibility of the Maybe there should be a new |
I ran into some problems in the unit tests with using the |
↪️ Pull Request
Writing to cache on shutdown can take a long time for large graphs, which makes it looks like Parcel is hanging after hitting
ctrl-c
. This moves the shutdown message toParcel.js
so it logs out right away, and also adds a progress bar indicator for the blobs written to cache.This behavior will only happen for large graphs (>5000 nodes) but this number can be changed if needed.
💻 Examples
Screen.Recording.2023-11-08.at.4.15.07.PM.mov
🚨 Test instructions
✔️ PR Todo