Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump some deps #9406

Merged
merged 9 commits into from
Dec 7, 2023
Merged

Bump some deps #9406

merged 9 commits into from
Dec 7, 2023

Conversation

mischnic
Copy link
Member

@mischnic mischnic commented Nov 25, 2023

Fixed:

  • Bump Babel, didn't appear to cause any problems
  • The new swc helpers added a comment containing =>, so minify the result before we check if a => was emitted in the code
  • tsc 5.2 apparently emits namespace instead of module now

Pinned dependencies:

  • Pin Vue because the transformer broke with 3.3.0 and custom script preprocessors: Vue 3.3.0 broke custom languages/preprocessors in scripts #9405
  • In the tests, we somehow do watcher.getEventsSince(dirThatDoesntExist). @parcel/watcher@>=2.3.0 throws an error here. The dir in question is e.g. parcel/packages/core/integration-tests/test/input/cbong0yqey6

@mischnic
Copy link
Member Author

mischnic commented Dec 6, 2023

The problem with the watcher (if it were bumped, this PR just pins it to a working version), is that with the OverlayFS, that input/<hash> dir only exists on the MemoryFS side, not the NodeFS, then MemoryFS#getEventsSince tries to get events for both FSs, but the folder exists in one of them.

One solution would be this

class OverlayFS
  async getEventsSince(
    dir: FilePath,
    snapshot: FilePath,
    opts: WatcherOptions,
  ): Promise<Array<Event>> {
    let writableEvents = this.writable.existsSync(path.dirname(snapshot))
      ? await this.writable.getEventsSince(dir, snapshot, opts)
      : [];
    let readableEvents = this.readable.existsSync(path.dirname(snapshot))
      ? await this.readable.getEventsSince(dir, snapshot, opts)
      : [];
    return [...writableEvents, ...readableEvents];
  }
}

@mischnic mischnic merged commit 296a787 into v2 Dec 7, 2023
13 of 15 checks passed
@mischnic mischnic deleted the bump-deps branch December 7, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants