Remove plugin version validation in canary and dev builds #9578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattcompiles
commented
Mar 13, 2024
package.json
Outdated
| @@ -31,7 +31,7 @@ | |||
| "test:integration-ci": "yarn workspace @parcel/integration-tests test-ci", | |||
| "test": "yarn test:unit && yarn test:integration", | |||
| "dev:release": "lerna publish -y --canary --preid dev --dist-tag=dev --exact --force-publish=* --no-git-tag-version --no-push", | |||
| "canary:release": "lerna publish -y --canary --preid canary --dist-tag=canary --exact --force-publish=* --no-git-tag-version --no-push", | |||
| "canary:release": "PARCEL_CANARY_BUILD=true lerna publish -y --canary --preid canary --dist-tag=canary --exact --force-publish=* --no-git-tag-version --no-push", | |||
There was a problem hiding this comment.
I'm assuming this will be forwarded to the build step?
There was a problem hiding this comment.
I tested this with a dev-release and it looks good.
mattcompiles
changed the title
mattcompiles
requested review from
devongovett and
MonicaOlejniczak
and removed request for
devongovett
MonicaOlejniczak
approved these changes
Mar 13, 2024
devongovett
reviewed
Mar 13, 2024
| "dev:release": "lerna publish -y --canary --preid dev --dist-tag=dev --exact --force-publish=* --no-git-tag-version --no-push", | ||
| "canary:release": "lerna publish -y --canary --preid canary --dist-tag=canary --exact --force-publish=* --no-git-tag-version --no-push", | ||
| "dev:release": "SKIP_PLUGIN_COMPATIBILITY_CHECK=true lerna publish -y --canary --preid dev --dist-tag=dev --exact --force-publish=* --no-git-tag-version --no-push", | ||
| "canary:release": "SKIP_PLUGIN_COMPATIBILITY_CHECK=true lerna publish -y --canary --preid canary --dist-tag=canary --exact --force-publish=* --no-git-tag-version --no-push", |
There was a problem hiding this comment.
wouldn't these need to be set during the build, not during publishing?
There was a problem hiding this comment.
This works because the actual build is triggered by the prepublishOnly npm hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
Remove plugin version validation in dev/canary/nightly builds as they don't use semver and will always fail.
✔️ PR Todo