Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-pin Rust from 1.77 back to stable #9724

Merged
merged 2 commits into from
May 20, 2024
Merged

Conversation

marcins
Copy link
Contributor

@marcins marcins commented May 20, 2024

↪️ Pull Request

We had pinned the Rust version at 1.77 due to issues with 1.78 and Parcel. With the SWC bump now merged it seems that Parcel is stable with Rust 1.78, so this change reverts the "pinning".

Rather than just pin to 1.78 we've gone with stable as we had before - usually Rust bumps don't cause issues, so it's probably generally fine to stay on latest stable rust and only pin if there's an issue found.

🚨 Test instructions

Tested a dev build internally against our very large web application.

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@marcins marcins requested a review from a team May 20, 2024 04:53
@marcins marcins added this pull request to the merge queue May 20, 2024
Merged via the queue into v2 with commit db3ca09 May 20, 2024
25 of 26 checks passed
@mischnic
Copy link
Member

So you're saying that the SWC bump fixed the Rust version problem. And the NAPI bump only made it worse?

@mischnic mischnic deleted the mszczepanski/unpin-rust-1.77 branch May 20, 2024 07:40
@marcins
Copy link
Contributor Author

marcins commented May 21, 2024

So you're saying that the SWC bump fixed the Rust version problem. And the NAPI bump only made it worse?

It seems the SWC bump fixes issues with using Rust 1.78, though if it's just the Windows integration tests being flaky, then I've seen that with all combinations lately so I don't think anything has fixed those reliably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants