Improve support for mounted file systems on macOS #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some mounted file systems report a creation time of 0 - we still want to support these systems reporting a file as created and modified and properly treat it as created.
|
@devongovett Thoughts on merging this? Also, is there a proper way to run the tests - they don't seem to be passing (unrelated from my change from what I can tell)? |
|
Is there a way I can test this change? |
|
It happens internally for our own mounted VFS, but I think you might be able to repro with an NFS client or perhaps with a normal file system if you change the latency here to be greatly increased and then write and modify the file (while keeping the ctime as 0) |
devongovett
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some mounted file systems report a creation time of 0 - we want to support these systems reporting a file as created and modified and properly treat it as created.