Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to GitHub actions, platform-specific packages, and add arm prebuilds #144

Merged
merged 34 commits into from
Jul 2, 2023

Conversation

devongovett
Copy link
Member

@devongovett devongovett commented Jun 25, 2023

Fixes #143, closes #132, fixes #130, fixes #95

This migrates the watcher package to GitHub Actions for both test and release workflows. In addition, it moves to a new release strategy with separate npm packages for each OS/architecture. Each platform-specific package becomes an optional dependency of the main package, which npm/yarn/etc. will install when needed. This way you only need to download the binary for the platform you're on rather than all of them. This allows us to add even more prebuilds (here we add linux arm64 and armv7 builds, as well as android, and windows arm64) without bloating the package size for everyone.

cc. @bpasero not sure how VSCode is consuming this package, but wanted to give you a heads up in case this affects you.

@devongovett devongovett changed the title Migrate to GitHub actions Migrate to GitHub actions, platform-specific packages, and add arm prebuilds Jun 25, 2023
@devongovett devongovett marked this pull request as ready for review June 26, 2023 00:21
@devongovett
Copy link
Member Author

This is released in v2.2.0-alpha.1 if anyone would like to try it out on your hardware. Please report back if there are any issues!

@mgius-ae
Copy link

I'm consuming parcel-bundler via lerna + nx. After overriding to 2.2.0-alpha-1 I was able to install and build my project without node-gyp in the following configurations.

Alpine + node18 + arm/x86
Darwin + node18 + arm.

@bpasero
Copy link
Contributor

bpasero commented Oct 8, 2023

@devongovett thanks for the ping, I somehow missed it. We prefer our native module dependencies to be built as part of our CI and not by consuming prebuilt binaries. With these changes is there still a way to enforce building the native module on the machine?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate packages for precompiled binaries ship arm64 binary musl (Alpine) prebuild for darwin-arm64
3 participants