-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Watcher implementations #2
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yeah I was planning on writing some tests to ensure consistency next. |
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds subscribe and unsubscribe methods to watch for changes to a directory. There are several backends:
Unlike nsfw, which starts up a thread per watched directory, fschanges starts up a single thread per backend and adds multiple watchers to it. Once all watchers have been closed, the backend thread is also closed.
Events are also denounced. Rather than spamming the JS thread when file changes come in, we queue up changes and emit them when things settle down. This is very useful for e.g. npm installs, git checkouts, or other large changes where we end up calling into JS only once with all of the events rather than separately for each one.
Another advantage to having the watchers be part of this package is that we can keep our in-memory snapshot up to date incrementally instead of potentially traversing the entire filesystem again on exit. This should make Windows and Linux a bit faster.