-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[T-242] Docker for alpine and centos binaries #24
Conversation
|
@mischnic awesome, thanks for the fast review. Knew alpine ran musl didn't know you needed to install that package, appears to have fixed it. Thanks! Read about centos only supporting 32bit |
prebuild might support fallback to 32bit, but having libraries with different architectures can cause problems on linux: if the 32bit watcher library links dynamically to glibc, then glibc needs to be installed in a 32bit variant as well (and Node at runtime needs to likely be 32 bit as well). I'm not sure how this works out on centos. |
Another possibility: loading glibc via |
Isn't it used for the BruteForceBackend? |
What do you mean? |
@mischnic I mean it's used for So we can't really fallback to |
Ah, you're right |
Rewrote the readDirTree to support centos without needing fts
|
The task T-242 has been marked as "Done". |
This PR aims to create binaries for alpine and linux versions that use an older libc than the one we use in CI (apparently centos is a good target to build against as it's using a very old libc version... source:
prebuild
)Using docker this PR virtualises
centos
andalpine
using the docker images by theprebuild
project.Related #23 #18
Closes T-242