Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #69 add security scanners #70

Merged
merged 1 commit into from
Sep 28, 2021
Merged

fix #69 add security scanners #70

merged 1 commit into from
Sep 28, 2021

Conversation

prybalko
Copy link
Contributor

  • add Trivy scanner for dependencies
  • add CodeQL scanner for js/ts code

Results of the scanning is going to be available in https://github.com/paritytech/banana_split/security/code-scanning

TarikGul
TarikGul approved these changes Sep 28, 2021
View reviewed changes
Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

vas3k
vas3k approved these changes Sep 28, 2021
View reviewed changes
Copy link

@vas3k vas3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@prybalko prybalko merged commit 19bc8b3 into master Sep 28, 2021
@prybalko prybalko deleted the add-security-scanners branch September 28, 2021 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TarikGul TarikGul TarikGul approved these changes

@vas3k vas3k vas3k approved these changes

@kirushik kirushik kirushik approved these changes

@AndreiEres AndreiEres Awaiting requested review from AndreiEres

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prybalko @kirushik @vas3k @TarikGul