Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Adjust description text and CSS styles #78

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

vas3k
Copy link

@vas3k vas3k commented Dec 6, 2021

  • Updated description text on the main page to make it clearer to novice users what it is and what it can be used for
  • Prettify CSS styles

TADA 🚀

Screen 2021-12-06 at 13 53 32

Copy link
Contributor

@kirushik kirushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super-attached to my wording — but I'd still say that the general idea of a) printouts going into non-transparent envelopes and b) being distributed across multiple locations is something we'd better communicate explicitly.

I also miss my tagline ("Shamir Secret Sharing for people with friends") a bit — it also implied the same idea; but I would accept this not being aligned with the general style of our communication anymore.

prybalko
prybalko previously approved these changes Dec 7, 2021
@vas3k
Copy link
Author

vas3k commented Dec 8, 2021

@kirushik

but I'd still say that the general idea of a) printouts going into non-transparent envelopes and b) being distributed across multiple locations is something we'd better communicate explicitly.

Good suggestion, commited

I also miss my tagline ("Shamir Secret Sharing for people with friends") a bit

I wanted to keep it, but it just didn't seem to fit the style of this How To. However, this tagline is still the description of the NPM package and will be visible to everyone who downloads and runs it :)

Please re-review

kirushik
kirushik previously approved these changes Dec 8, 2021
prybalko
prybalko previously approved these changes Dec 8, 2021
Update src/components/GeneralInfo.vue

Co-authored-by: Kirill Pimenov <kirill@parity.io>
@prybalko prybalko dismissed stale reviews from kirushik and themself via 282581c December 8, 2021 11:13
@kirushik kirushik merged commit fbf95db into master Dec 8, 2021
This was referenced Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants