Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always show git hash in bs version #81

Merged
merged 1 commit into from
Dec 13, 2021
Merged

Conversation

prybalko
Copy link
Contributor

For a tagged commit it's going to bev0.3.0-0-g2c91c85

@kirushik
Copy link
Contributor

@prybalko well, we can't retroactively apply that to the existing 0.3.0, can we?
Please tag 0.3.1 with this patch in and deploy to bs.parity.io

@prybalko
Copy link
Contributor Author

prybalko commented Dec 10, 2021

I think I can edit/remove existing tags

@prybalko
Copy link
Contributor Author

UPD: removed v0.3.0 tag.

@kirushik
Copy link
Contributor

@prybalko currently https://bs.parity.io/ says v0.2.0-91-g2c91c85 — which doesn't feel accurate to me.

Can we please in the future make releases of BananaSplit a big, manual thing?
It's not your regular webservice which can be patched in a jiffy, each release is expected to stay with its users for years without much in a way of updating.
We can't afford people getting random occasional versions without even clear versioning — and then sticking to them.

@prybalko prybalko merged commit bc4c9bc into master Dec 13, 2021
@prybalko prybalko deleted the always-show-git-hash branch December 13, 2021 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants