Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

chore: upgrade to capi beta40 #197

Merged
merged 10 commits into from
Jun 2, 2023
Merged

chore: upgrade to capi beta40 #197

merged 10 commits into from
Jun 2, 2023

Conversation

peetzweg
Copy link
Member

@peetzweg peetzweg commented Jun 1, 2023

Just upgrading to capi beta40 on it's own to debug the built error with capi 40 in the #186 pr.

@netlify
Copy link

netlify bot commented Jun 1, 2023

Deploy Preview for capi-multisig ready!

Name Link
🔨 Latest commit 6434c53
🔍 Latest deploy log https://app.netlify.com/sites/capi-multisig/deploys/6479a9c18f19860008c51a87
😎 Deploy Preview https://deploy-preview-197--capi-multisig.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@peetzweg peetzweg requested review from kratico and removed request for ryanleecode and statictype June 1, 2023 07:57
@peetzweg
Copy link
Member Author

peetzweg commented Jun 1, 2023

@kratico cc @ryanleecode
Getting these errors on the console in the deployed version. App is not loading.

Screenshot 2023-06-01 at 09 59 42 Screenshot 2023-06-01 at 09 59 53

I'm a bit confused why the errors are different to the error we had in #186 . In #186 we weren't able to build for production, here it works but results in the error above in the deployment. 🤔
The changes regarding to the capi upgrade look the same to me.

@ryanleecode
Copy link
Contributor

Did you also commit the updates to your vite config?

1 similar comment
@ryanleecode
Copy link
Contributor

Did you also commit the updates to your vite config?

@kratico
Copy link
Contributor

kratico commented Jun 1, 2023

The package.json hasn't been updated

"capi": "0.1.0-beta.38",

@peetzweg
Copy link
Member Author

peetzweg commented Jun 1, 2023

Ah yes you both are right @kratico @ryanleecode . Just pushed the actual upgrade to beta40. Which resulted in the same error as in #186, therefore I also adapted the vite.config.ts.

https://deploy-preview-197--capi-multisig.netlify.app/

Screenshot 2023-06-01 at 14 03 04

@ryanleecode
Copy link
Contributor

Were the rollup options in vite config there before? What happens when they are removed

@peetzweg
Copy link
Member Author

peetzweg commented Jun 1, 2023

Were the rollup options in vite config there before? What happens when they are removed

No they weren't. Without them the pnpm build step fails:

Screenshot 2023-06-01 at 14 18 56

www/index.html Show resolved Hide resolved
ryanleecode
ryanleecode previously approved these changes Jun 1, 2023
netlify.toml Outdated Show resolved Hide resolved
@peetzweg
Copy link
Member Author

peetzweg commented Jun 2, 2023

Okay seems the combination of these two changes are enough to make it work. I've added a comment that this should be removed once paritytech/capi#1038 is closed.

<script>
// TODO remove once closed https://github.com/paritytech/capi/issues/1038
// temporary capi workaround
window.process = { env: {} };
</script>

define: {
// TODO remove once closed https://github.com/paritytech/capi/issues/1038
// temporary capi workaround
"process.env.CAPI_SERVER": process.env.CAPI_SERVER,
"process.env.CAPI_TARGET": process.env.CAPI_TARGET,
},

@statictype statictype merged commit 3376fb0 into main Jun 2, 2023
@statictype statictype deleted the chore/upgrade-capi-40 branch June 2, 2023 11:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants