-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
✅ Deploy Preview for capi-multisig ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@kratico cc @ryanleecode I'm a bit confused why the errors are different to the error we had in #186 . In #186 we weren't able to build for production, here it works but results in the error above in the deployment. 🤔 |
Did you also commit the updates to your vite config? |
1 similar comment
Did you also commit the updates to your vite config? |
The capi-multisig-app/package.json Line 15 in d861039
|
Ah yes you both are right @kratico @ryanleecode . Just pushed the actual upgrade to beta40. Which resulted in the same error as in #186, therefore I also adapted the https://deploy-preview-197--capi-multisig.netlify.app/ |
Were the rollup options in vite config there before? What happens when they are removed |
Okay seems the combination of these two changes are enough to make it work. I've added a comment that this should be removed once paritytech/capi#1038 is closed. capi-multisig-app/www/index.html Lines 18 to 22 in 6434c53
capi-multisig-app/www/vite.config.ts Lines 16 to 21 in 6434c53
|
Just upgrading to capi beta40 on it's own to debug the built error with capi 40 in the #186 pr.