This repository has been archived by the owner on Sep 14, 2023. It is now read-only.
chore: high level api speccing #107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjjfvi
reviewed
Jun 13, 2022
Comment on lines
+1
to
+17
| export const enum NodeKind { | ||
| Chain = "Chain", | ||
| Metadata = "Metadata", | ||
| Pallet = "Pallet", | ||
| Block = "Block", | ||
| StorageItem = "StorageItem", | ||
| StorageMap = "StorageMap", | ||
| StorageMapValue = "StorageMapValue", | ||
| StorageMapKeysPage = "StorageMapKeysPage", | ||
| Access = "Access", | ||
| ExtrinsicFactory = "ExtrinsicFactory", | ||
| Extrinsic = "Extrinsic", | ||
| SignedExtrinsic = "SignedExtrinsic", | ||
| Event = "Event", | ||
| Read = "Read", | ||
| Subscribe = "Subscribe", | ||
| } |
There was a problem hiding this comment.
I thought I had rid this land of these pests!
There was a problem hiding this comment.
Whoops. String literals from here on out. Fingers crossed!
tjjfvi
reviewed
Jun 13, 2022
Comment on lines
+19
to
+21
| sign(sign: (message: Uint8Array) => Uint8Array): SignedExtrinsic { | ||
| return new SignedExtrinsic(this as Extrinsic, sign); | ||
| } |
There was a problem hiding this comment.
Needs to also take extra and additional
|
I think all of these node classes should be named |
|
Technically, these will ultimately be effects (or at least the result of the final chained method call). Perhaps we prefix with |
|
I think the |
|
Closing in favor of #132 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.