This repository has been archived by the owner on Sep 14, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kratico
commented
Jun 14, 2023
kratico
force-pushed
the
feat/bundler-size
branch
from
June 14, 2023 16:12
b65fe03
to
b545e87
Compare
kratico
force-pushed
the
feat/bundler-size
branch
from
June 14, 2023 17:34
b545e87
to
c9f0643
Compare
kratico
force-pushed
the
feat/bundler-size
branch
from
June 14, 2023 18:15
4b44f1b
to
7b43191
Compare
tjjfvi
reviewed
Jun 14, 2023
Co-authored-by: T6 <t6@t6.fyi>
harrysolovay
approved these changes
Jun 15, 2023
tjjfvi
approved these changes
Jun 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but this won't successfully merge until #1080 is merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1053 #1038
This PR improves
webpack
configuration becauseexternals["node:*"]
is no longer requiredvite
configuration becausebuild.rollupOptions.shimMissingExports
is no longer requiredWebpack Bundle Analyzer before and after this change
vite-bundle-visualizer
after this change