Skip to content
This repository has been archived by the owner on Sep 14, 2023. It is now read-only.

fix: run bin abort signal #782

Merged
merged 3 commits into from
Mar 22, 2023
Merged

fix: run bin abort signal #782

merged 3 commits into from
Mar 22, 2023

Conversation

ryanleecode
Copy link
Contributor

fixes #735

@ryanleecode ryanleecode marked this pull request as ready for review March 22, 2023 21:12
@tjjfvi
Copy link
Contributor

tjjfvi commented Mar 22, 2023

Ah, good catch. Can you make sure this is done everywhere else we use Deno.Command? (Or is this the only relevant place?)

@ryanleecode
Copy link
Contributor Author

should be good now

@harrysolovay
Copy link
Contributor

harrysolovay commented Mar 22, 2023 •
edited
Loading

It strikes me that this change should (possibly) be based off of #777.

EDIT

This is actually not the case

@ryanleecode ryanleecode added this pull request to the merge queue Mar 22, 2023
@ryanleecode ryanleecode merged commit 0aaa179 into main Mar 22, 2023
@ryanleecode ryanleecode deleted the fix/frame-bin-provider branch March 22, 2023 22:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tjjfvi tjjfvi tjjfvi approved these changes

@harrysolovay harrysolovay Awaiting requested review from harrysolovay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

framebinprovider doesn't check if process is already killed
3 participants
@ryanleecode @tjjfvi @harrysolovay