Skip to content
This repository has been archived by the owner on Sep 14, 2023. It is now read-only.

feat: flat codegen #867

Merged
merged 9 commits into from
Apr 11, 2023
Merged

feat: flat codegen #867

merged 9 commits into from
Apr 11, 2023

Conversation

tjjfvi
Copy link
Contributor

@tjjfvi tjjfvi commented Apr 10, 2023 •
edited
Loading

This exposes all types from the codegen root sans namespaces. When type names conflict, relevant module sections are prepended to disambiguate (e.g. PalletBalancesEvent and XcmV2Junctions).

Additionally, this makes @capi/foo an alias for @capi/foo/mod.js, so we can use the same import paths for both deno and node.

@harrysolovay
Copy link
Contributor

May also resolve #849

@tjjfvi tjjfvi changed the title feat: flat codegen [experiment] feat: flat codegen Apr 10, 2023
@tjjfvi tjjfvi marked this pull request as ready for review April 10, 2023 23:32
harrysolovay
harrysolovay approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@harrysolovay harrysolovay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just incredible. Huge improvement.

@tjjfvi tjjfvi added this pull request to the merge queue Apr 11, 2023
Merged via the queue into main with commit ad7005e Apr 11, 2023
@tjjfvi tjjfvi deleted the flat-codegen branch April 11, 2023 00:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@harrysolovay harrysolovay harrysolovay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rework codegen to stave off LSP file count limit Typescript autocompletion is laggy in VSCode
2 participants
@tjjfvi @harrysolovay