This repository has been archived by the owner on Sep 14, 2023. It is now read-only.
refactor: make dev users non-chain-specific #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjjfvi
reviewed
Apr 18, 2023
harrysolovay
force-pushed
the
test-users-from-root
branch
from
bf6c630
to
5c544b6
Compare
tjjfvi
approved these changes
Apr 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change exposes the
createUsersutil throughcapiinstead of through chain-specific codegen (the dev users are not chain-specific, after all). Also, given that we use the term "dev" in the context of dev nets, let's do the same for test users. The creation util is now exposed throughcapiitself, so let's renamecreateUserstocreateDevUsers; hopefully this makes clear that its not to be used outside of the context of Capi devnets.