This repository has been archived by the owner on Sep 14, 2023. It is now read-only.
chore: clean up weights + estimates #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrysolovay
commented
May 3, 2023
|
yes, it is already on Kusama as far as I see. it's part of runtime |
harrysolovay
force-pushed
the
clean-up-estimates
branch
from
25d9fd8
to
f1a3ce8
Compare
harrysolovay
commented
May 5, 2023
peetzweg
reviewed
May 8, 2023
peetzweg
reviewed
May 8, 2023
tjjfvi
reviewed
May 8, 2023
tjjfvi
reviewed
May 8, 2023
tjjfvi
reviewed
May 8, 2023
tjjfvi
approved these changes
May 8, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
estimateFeetoweight(which is what it actually is)estimatemethod toExtrinsicRunewhich actually returns the estimate (abigint)NOTE: the
TransactionPaymentApi_query_weight_to_feeendpoint is currently Westend-only, but will supposedly make its way into Polkadot (correct @statictype ?).