Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update validation for renamed FFI functions #816

Merged
merged 2 commits into from
Nov 10, 2022
Merged

Update validation for renamed FFI functions #816

merged 2 commits into from
Nov 10, 2022

Conversation

ascjones
Copy link
Collaborator

@ascjones ascjones commented Nov 10, 2022 •
edited
Loading

seal prefixes have been removed, need to check for the module name now.

See use-ink/ink#1482 (comment)

@ascjones ascjones mentioned this pull request Nov 10, 2022
Merged
@ascjones ascjones mentioned this pull request Nov 10, 2022
Merged
@athei
Copy link
Contributor

athei commented Nov 10, 2022

Will the CI use it automatically if we do a release?

@ascjones
Copy link
Collaborator Author

It will use master https://github.com/paritytech/scripts/blob/8d3902c5356f6efed2fc116b234e83b58a69f656/dockerfiles/contracts-ci-linux/Dockerfile#L70

@ascjones ascjones merged commit 65d6419 into master Nov 10, 2022
@ascjones ascjones deleted the aj/fix-validate-wasm branch November 10, 2022 11:06
@ascjones ascjones mentioned this pull request Nov 22, 2022
Merged
@ascjones ascjones mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@athei athei athei approved these changes

@cmichi cmichi Awaiting requested review from cmichi cmichi is a code owner

@HCastano HCastano Awaiting requested review from HCastano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ascjones @athei